-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add downloadFile
method in file
model
#1518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
added a commit
to cozy/cozy-ui
that referenced
this pull request
Aug 26, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Aug 26, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
to cozy/cozy-ui
that referenced
this pull request
Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `react/Vierwer/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
added a commit
to cozy/cozy-ui
that referenced
this pull request
Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `react/Vierwer/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
force-pushed
the
docs/fix_links_constructor
branch
from
September 9, 2024 13:30
6e29966
to
9054503
Compare
Base automatically changed from
docs/fix_links_constructor
to
feat/meta_offline
September 9, 2024 13:40
For the Flagship app offline feature, we want to make some files available offline To make this possible, we want the cozy-apps to download files as usual except when they are hosted in the FlagshipApp In that scenario, we want the cozy-app to call the new `downloadFile` intent Also to ease future compatibility, we want to implement a new method hosted in the `file` model instead of in the collection as before So in order to handle offline files, the cozy-app will now need to call `downloadFile()` method from `models/file`
Ldoppea
force-pushed
the
feat/download_files_flagship
branch
from
September 9, 2024 13:41
7b1ae64
to
ce57209
Compare
Ldoppea
added a commit
that referenced
this pull request
Sep 11, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
that referenced
this pull request
Sep 12, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
that referenced
this pull request
Sep 12, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Sep 12, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `cozy-viewer/src/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
1 task
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `cozy-viewer/src/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
added a commit
that referenced
this pull request
Sep 13, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
that referenced
this pull request
Sep 19, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
that referenced
this pull request
Sep 19, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
that referenced
this pull request
Sep 24, 2024
Previous implementation would not be backward compatible with older Flagship app versions By checking for method availability, we ensure the code is called only on the correct Flagship app versions, otherwise the old process is called Related PR: #1518
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `cozy-viewer/src/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `cozy-viewer/src/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Sep 25, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Flagship app offline feature, we want to make some files available offline
To make this possible, we want the cozy-apps to download files as usual except when they are hosted in the FlagshipApp
In that scenario, we want the cozy-app to call the new
downloadFile
intentAlso to ease future compatibility, we want to implement a new method hosted in the
file
model instead of in the collection as beforeSo in order to handle offline files, the cozy-app will now need to call
downloadFile()
method frommodels/file
Related PRs:
downloadFile()
method from cozy-client cozy-ui#2690